On Sat, Jul 14, 2018 at 07:49:35PM +0800, Eryu Guan wrote: > On Tue, Jul 03, 2018 at 09:50:47PM -0700, Darrick J. Wong wrote: > > Hi all, > > > > Several months ago I tried testing xfs with quotas enabled and was > > surprised at the number of failures. Since then I've been on a bug hunt > > to triage the mess, and the following series fixes some of the low > > hanging fruit. Some of these are minor behavioral variations when quota > > are enabled, and other fixes upgrade old v4 tests to work on v5 > > filesystems. > > (Sorry for the late review..) > > I take parts of the patchset (patch 1 3 5-7) for this week's update, as > the patches don't have hard dependencies. I dropped patch 2 and 4 for > now. Ok, thank you! I'll work on 2 and 4 for next time. :) --D > Thanks, > Eryu > > > > > To reproduce the results, run xfstests with > > 'MOUNT_OPTIONS="-o usrquota,grpquota,prjquota"' on a v5 filesystem. > > Strike the ',grpquota' on a v4 filesystem. > > > > The first patch fixes differences in the golden output when quotas are > > enabled on xfs -- mmap writes (intentionally) crashing with SIGBUS when > > quota updates fail vs. msync failing with EIO. > > > > The second patch fixes all the tests that require a specific quota mount > > option configuration to filter out any quota options present in > > MOUNT_OPTIONS. > > > > The third patch updates xfs/001 to work with XFS v5 filesystems since > > there was nothing particularly v4 specific about it. > > > > The fourth patch enables tests that require a v4 format to filter out v5 > > mount options (such as grpquota) so that they can run. > > > > Patch #5 upgrades xfs/288 to support XFS v5 since there was nothing > > particular to v4 about that test. > > > > Patch #6 fixes a problem in generic/338 where switching the disk backend > > to dm-error on a xfs with quotas enabled causes the fs to go down with a > > dirty log which is not recovered prior to the end of the test. This was > > originally a regression test for a NULL pointer dereference after the fs > > shuts down, so we can skip the post-test fsck. > > > > Patch #7 filters 'quota info will be regenerated on next quota mount' > > messages from the xfs_repair golden output. > > > > --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
