On Wed, Jul 11, 2018 at 10:15:51AM -0700, Darrick J. Wong wrote: > Hmm, this troubles me slightly -- a short time ago you removed the "trim > this data fork mapping to the first overlap with a cow fork mapping" > (i.e. xfs_reflink_trim_irec_to_next_cow) behavior on the grounds that > _writepage_map calls _map_blocks for every block in the page and so it > was unnecessary. But this seems to put that back. Why is that? Because back then map_blocks did a lookup in the COW fork everytime (unless we are already on a COW mapping), and this patch wants to only look it up when the COW fork actually changed, so the trim is required now. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
