On Fri, Jul 06, 2018 at 03:42:50PM +1000, Dave Chinner wrote: > This mechanism solves the above problem by storing the newly > allocated block in the in-memory COW fork and doesn't modify the > data fork until after the data write IO completes. IOWs, we do > allocation before the write IO, and do the data fork and BMBT > manipulation after the IO completes. i.e. we do the local->extent > data fork modification at IO completion using the extent that was > stored in the in memory COW fork. > > Hence I think the inline data write path needs to piggy back on the > iomap COW path that we use for writing to shared extents if the > write would cause a data fork format change. I'm not even sure we need the cow infrastructure for that, but yes, we need the format conversion to be driven from the I/O completion handler for buffer I/O writeback, and for direct I/O (including AIO) as well. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html