Re: [PATCH 01/24] xfs: cow unwritten conversion uses uninitialized dfops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 02, 2018 at 01:32:41PM -0400, Brian Foster wrote:
> On Mon, Jul 02, 2018 at 06:43:04AM -0700, Christoph Hellwig wrote:
> > On Thu, Jun 28, 2018 at 12:36:13PM -0400, Brian Foster wrote:
> > > A couple COW fork unwritten extent conversion helpers pass an
> > > uninitialized dfops pointer to xfs_bmapi_write(). This does not
> > > cause problems because conversion does not use a transaction or the
> > > dfops structure for the COW fork.  Drop the uninitialized usage of
> > > dfops in these codepaths and pass NULL along to xfs_bmapi_write()
> > > instead.
> > 
> > Looks good.
> > 
> > Is this something we should maybe queue up for 4.18?
> > 
> 
> That might make sense because of all the refactoring, but otherwise I
> don't have a strong opinion. Let's see what Darrick wants to do...

AFAICT this only eliminates the passing around of an unus{ed,able} dfops
parameter, right?  We're not fixing a regression or some other breakage,
just eliminating cpu cycle waste, so I think this can soak (along with
everything else) until 4.19.

--D

> Brian
> 
> > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux