On Mon, Jul 02, 2018 at 06:45:06AM -0700, Christoph Hellwig wrote: > > - args->dfops = dfops; > > args->total = total; > > args->whichfork = XFS_DATA_FORK; > > args->trans = tp; > > + ASSERT(tp->t_dfops || !first); > > Nitpick: I like to have calling convention asserts always at the > beginning of the function to clearly see the assumed state on the first > look. > Ok, I'll fix that up. Brian > Otherwise looks fine: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
