On Thu, Jun 28, 2018 at 12:36:32PM -0400, Brian Foster wrote: > The xfs_btree_cur.bc_private.a.dfops field is only ever initialized > by the refcountbt cursor init function. The only caller of that > function with a non-NULL dfops is from deferred completion context, > which already has attached to ->t_dfops. > > In addition to that, the only actual reference of a.dfops is the > cursor duplication function, which means the field is effectively > unused. > > Remove the dfops field from the bc_private.a union. Any future users > can acquire the dfops from the transaction. This patch does not > change behavior. Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html