On Thu, Jun 28, 2018 at 12:36:17PM -0400, Brian Foster wrote: > Log recovery passes down a central dfops structure to recovery > handlers for bui and cui log items. Each of these handlers allocates > and commits a transaction and defers any remaining operations to be > completed by the main recovery sequence. > > Since dfops outlives the transaction in this context, set and clear > ->t_dfops appropriately such that the *_finish_item() paths and > below (i.e., xfs_bmapi*()) can expect to find the dfops in the > transaction without it being committed with the dfops attached. This > is required because transaction commit expects that an associated > dfops is finished and in this context the dfops may be populated at > commit time. Do we want comments explaining this in the code? Otherwise looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
