On Fri, Jun 22, 2018 at 02:21:04PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Zorro Lang reports that generic/485 blows an assert on a filesystem with > 512 byte blocks. The test tries to fallocate a post-eof extent at the > maximum file size and calls insert range to shift the extents right by > two blocks. On a 512b block filesystem this causes startoff to overflow > the 54-bit startoff field, leading to the assert. > > Therefore, always check the rightmost extent to see if it would overflow > prior to invoking the insert range machinery. > > Reported-by: zlang@xxxxxxxxxx > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200137 > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > Reviewed-by: Allison Henderson <allison.henderson@xxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html