On Thu, Jun 21, 2018 at 03:55:08PM -0700, Darrick J. Wong wrote: > On Fri, Jun 22, 2018 at 08:34:06AM +1000, Dave Chinner wrote: > > On Wed, Jun 20, 2018 at 12:31:42AM -0700, Christoph Hellwig wrote: > > > On Mon, Jun 18, 2018 at 09:54:05PM -0700, Darrick J. Wong wrote: > > > > ...it's also weird that xfs_bmap_punch_delalloc_range calls xfs_bunmapi > > > > with no transaction and a xfs_defer that we dump on the ground. > > > > > > > > So yes, I think the patch does fix the crash, but it's kinda gross. > > > > > > > > Thoughts? > > > > > > I've got an alternative solution: > > > > > > http://git.infradead.org/users/hch/xfs.git/commitdiff/a1c0685b2085b448cbe02f0f9ff0c8771e3f4496 > > > > > > The only bit that is missing is removing the now unused support for > > > a NULL tp in __xfs_bunmapi.. > > > > Ah, I forgot about that patch. Thanks for the reminder, Christoph! > > > > Darrick, can we get Christoph's patch in as a standalone bug fix > > rather than wait for the bufferhead removal to be merged? > > Ok, will do. AFAICT if I merge that patch then I can drop this one, > right? Yup, should be able to, as this is the only vector into the problem code. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
