Re: [PATCH] xfs_bmap: don't reject -e

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 21, 2018 at 02:32:44PM -0500, Eric Sandeen wrote:
> On 6/21/18 1:49 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> > 
> > The xfs_io bmap command has an -e switch that prints delalloc extents
> > without fsync'ing the file first.  The xfs_bmap manpage says it'll pass
> > -e through, but it doesn't.  Fix the script and fix the weird manpage
> > discrepancy where it doesn't list -e in the available options but
> > discusses it anyway.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> need to fix it all up for "-c" as well, right?

The cow fork bmap only works if CONFIG_XFS_DEBUG=y (per review comment
when reflink was being developed) so I never bothered wiring it up from
xfs_bmap.sh, only xfs_io.

> and I think:
> 
> Fixes: 7536ce44f6 ("xfs_io: bmap should support querying CoW fork, shared blocks")

Ok.

--D

> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux