>From 7208bf13827fa7c7d6196ee20f7678eff0d29b36 Mon Sep 17 00:00:00 2001 From: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> Date: Thu, 21 Jun 2018 14:15:10 +0900 Subject: [PATCH] Makefile: Fix backtrace breakage Dave Chinner noticed that backtrace part is missing in a lockdep report. [ 68.760085] the existing dependency chain (in reverse order) is: [ 69.258520] [ 69.258520] -> #1 (fs_reclaim){+.+.}: [ 69.623516] [ 69.623516] -> #0 (sb_internal){.+.+}: [ 70.152322] [ 70.152322] other info that might help us debug this: Since the kernel was using CONFIG_FTRACE_MCOUNT_RECORD=n && CONFIG_FRAME_POINTER=n, objtool_args was not properly calculated due to incorrectly placed "endif" in commit 96f60dfa5819a065 ("trace: Use -mcount-record for dynamic ftrace"). Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> Cc: Dave Chinner <david@xxxxxxxxxxxxx> Cc: Andi Kleen <ak@xxxxxxxxxxxxxxx> Cc: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> --- scripts/Makefile.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 34d9e9c..55f22f4 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -239,6 +239,7 @@ cmd_record_mcount = \ "$(CC_FLAGS_FTRACE)" ]; then \ $(sub_cmd_record_mcount) \ fi; +endif endif # CONFIG_FTRACE_MCOUNT_RECORD ifdef CONFIG_STACK_VALIDATION @@ -263,7 +264,6 @@ ifneq ($(RETPOLINE_CFLAGS),) objtool_args += --retpoline endif endif -endif ifdef CONFIG_MODVERSIONS -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html