From: Jeff Mahoney <jeffm@xxxxxxxx> Commit 051b4e37f5e (mkfs: factor AG alignment) factored out the AG alignment code into a separate function. It got rid of redundant checks for dswidth != 0 but did too good a job since now it doesn't check at all. When we hit the check to see if agsize is a multiple of stripe width: (cfg->agsize % cfg->dswidth), we crash on a divide by zero. This patch re-adds the check to the top of align_ag_geometry. Fixes: 051b4e37f5e (mkfs: factor AG alignment) Signed-off-by: Jeff Mahoney <jeffm@xxxxxxxx> --- mkfs/xfs_mkfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c index 78d0ce5d..28a7e70c 100644 --- a/mkfs/xfs_mkfs.c +++ b/mkfs/xfs_mkfs.c @@ -2670,7 +2670,7 @@ align_ag_geometry( uint64_t tmp_agsize; int dsunit = cfg->dsunit; - if (!dsunit) + if (!dsunit || !cfg->dswidth) goto validate; /* -- 2.15.1 -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
