On Fri, Jun 15, 2018 at 11:43:14AM +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > A log recovery failure has been reproduced where a symlink inode has > a zero length in extent form. It was caused by a shutdown during a > combined fstress+fsmark workload. > > To fix it, we have to allow zero length symlink inodes through > xfs_dinode_verify() during log recovery. We already specifically > check and allow this case in the shortform symlink fork verifier, > but in this case we don't get that far, and the inode is not in > shortform format. > > Update the dinode verifier to handle this case, and change the > symlink fork verifier to only allow this case to exist during log > recovery. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> Self-NAK on this - I've got a patch that prevents zero length symlinks from going to disk, so allowing them through log recovery is not necessary - they are always invalid..... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
