We already track the page uptodate status based on the buffer uptodate
status, which is updated whenever reading or zeroing blocks.
This code has been there since commit a ptool commit in 2002, which
claims to:
"merge" the 2.4 fsx fix for block size < page size to 2.5. This needed
major changes to actually fit.
and isn't present in other writepage implementations.
Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>
Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
---
fs/xfs/xfs_aops.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index 026721c4991e..5c611c0784ca 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -850,7 +850,6 @@ xfs_writepage_map(
uint64_t offset;
int error = 0;
int count = 0;
- int uptodate = 1;
unsigned int new_type;
bh = head = page_buffers(page);
@@ -858,8 +857,6 @@ xfs_writepage_map(
do {
if (offset >= end_offset)
break;
- if (!buffer_uptodate(bh))
- uptodate = 0;
/*
* set_page_dirty dirties all buffers in a page, independent
@@ -923,9 +920,6 @@ xfs_writepage_map(
} while (offset += len, ((bh = bh->b_this_page) != head));
- if (uptodate && bh == head)
- SetPageUptodate(page);
-
ASSERT(wpc->ioend || list_empty(&submit_list));
out:
--
2.17.1
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
