On Thu, Jun 14, 2018 at 09:02:11PM -0500, Eric Sandeen wrote: > > > On 6/14/18 8:57 PM, Eric Sandeen wrote: > > On 6/14/18 8:43 PM, Dave Chinner wrote: > >> From: Dave Chinner <dchinner@xxxxxxxxxx> > >> > >> A log recovery failure has been reproduced where a symlink inode has > >> a zero length in extent form. It was caused by a shutdown during a > >> combined fstress+fsmark workload. > >> > >> To fix it, we have to allow zero length symlink inodes through > >> xfs_dinode_verify() during log recovery. We already specifically > >> check and allow this case in the shortform symlink fork verifier, > >> but in this case we don't get that far, and the inode is not in > >> shortform format. > >> > >> Update the dinode verifier to handle this case, and change the > >> symlink fork verifier to only allow this case to exist during log > >> recovery. > >> > >> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > > > > Looks reasonable. > > > > Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx> > > Also probably worth tagging with > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200063 Why? I didn't know that existed until you pointed it out, and I still haven't looked at it as I write this.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
