On 6/12/18 5:10 PM, Darrick J. Wong wrote: > On Tue, Jun 12, 2018 at 02:45:40PM -0500, Eric Sandeen wrote: >> On 6/12/18 2:31 PM, Eric Sandeen wrote: >>> Simple move with no changes, next patch will parameterize @sysconfdir@ >>> >>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> >>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx> >>> --- >>> man/man8/Makefile | 8 +- > > /me thinks this ought to go in the next patch, since that's where the > parameterization gets used. > well the makefile still needs to transmogrify mkfs.xfs.8.in to mkfs.xfs.8, and replacing all (nonexistent) instances of @sysconfdir@ via sed /will/ do that ;) yeah I thought about making it a mv but TBH that didn't seem worth the effort for no net change in behavior. -Eric >>> man/man8/mkfs.xfs.8 | 1015 ------------------------------------------------ >>> man/man8/mkfs.xfs.8.in | 1015 ++++++++++++++++++++++++++++++++++++++++++++++++ >>> 3 files changed, 1022 insertions(+), 1016 deletions(-) >>> delete mode 100644 man/man8/mkfs.xfs.8 >>> create mode 100644 man/man8/mkfs.xfs.8.in >> >> Well crud the point of mv-with-no-changes was to make git detect the >> rename :/ > > Works for me, at least I don't have to go dig out your changes. :) > > With that one thing moved, > Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > --D > >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
