Re: [PATCH v2 19/27] xfsprogs: Add delayed attributes error tag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 06/11/2018 10:28 AM, Darrick J. Wong wrote:
Subject: [PATCH v2 19/27] xfsprogs: Add delayed attributes error tag

Please identify the tool name in the subject when possible, e.g.

[PATCH v2 19/27] xfs_io: Add delayed attributes error tag

Otherwise looks ok, though in the end I suspect the xfs_errortag.h chunk
will be ported in from the kernel patch and this will be a separate
patch with just the xfs_io part.

Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

--D

Alrighty then, will update.  Thx!

Allison



On Sat, Jun 09, 2018 at 10:07:44PM -0700, Allison Henderson wrote:
Signed-off-by: Allison Henderson <allison.henderson@xxxxxxxxxx>
---
  io/inject.c           | 1 +
  libxfs/xfs_errortag.h | 5 ++++-
  2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/io/inject.c b/io/inject.c
index fc3cf25..2d6cc9c 100644
--- a/io/inject.c
+++ b/io/inject.c
@@ -63,6 +63,7 @@ error_tag(char *name)
  		{ XFS_ERRTAG_LOG_BAD_CRC,		"log_bad_crc" },
  		{ XFS_ERRTAG_LOG_ITEM_PIN,		"log_item_pin" },
  		{ XFS_ERRTAG_BUF_LRU_REF,		"buf_lru_ref" },
+		{ XFS_ERRTAG_DELAYED_ATTR,		"delayed_attr" },
  		{ XFS_ERRTAG_MAX,			NULL }
  	};
  	int	count;
diff --git a/libxfs/xfs_errortag.h b/libxfs/xfs_errortag.h
index bc1789d..f606ab6 100644
--- a/libxfs/xfs_errortag.h
+++ b/libxfs/xfs_errortag.h
@@ -65,7 +65,8 @@
  #define XFS_ERRTAG_LOG_BAD_CRC				29
  #define XFS_ERRTAG_LOG_ITEM_PIN				30
  #define XFS_ERRTAG_BUF_LRU_REF				31
-#define XFS_ERRTAG_MAX					32
+#define XFS_ERRTAG_DELAYED_ATTR			32
+#define XFS_ERRTAG_MAX					33
/*
   * Random factors for above tags, 1 means always, 2 means 1/2 time, etc.
@@ -102,5 +103,7 @@
  #define XFS_RANDOM_LOG_BAD_CRC				1
  #define XFS_RANDOM_LOG_ITEM_PIN				1
  #define XFS_RANDOM_BUF_LRU_REF				2
+#define XFS_RANDOM_DELAYED_ATTR			1
#endif /* __XFS_ERRORTAG_H_ */
+
--
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  https://urldefense.proofpoint.com/v2/url?u=http-3A__vger.kernel.org_majordomo-2Dinfo.html&d=DwIBAg&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=LHZQ8fHvy6wDKXGTWcm97burZH5sQKHRDMaY1UthQxc&m=QbTHukRdcKCnd1O8XZT7S_muyoJoMTtTL4i6k23zRGY&s=bhDah3NrmTekLEKtbCYu5KGb-r_-7o59FAmFdI_tqfM&e=
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  https://urldefense.proofpoint.com/v2/url?u=http-3A__vger.kernel.org_majordomo-2Dinfo.html&d=DwIBAg&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=LHZQ8fHvy6wDKXGTWcm97burZH5sQKHRDMaY1UthQxc&m=QbTHukRdcKCnd1O8XZT7S_muyoJoMTtTL4i6k23zRGY&s=bhDah3NrmTekLEKtbCYu5KGb-r_-7o59FAmFdI_tqfM&e=

--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux