Re: [PATCH v7 19/23] xfs: Add parent pointers to rename

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 06/10/2018 06:39 AM, Amir Goldstein wrote:
On Sun, Jun 10, 2018 at 8:05 AM, Allison Henderson
<allison.henderson@xxxxxxxxxx> wrote:
This patch removes the old parent pointer attribute during the
rename operation, and re-adds the updated parent pointer

Signed-off-by: Allison Henderson <allison.henderson@xxxxxxxxxx>
---
  fs/xfs/xfs_inode.c | 68 +++++++++++++++++++++++++++++++++++++++++-------------
  1 file changed, 52 insertions(+), 16 deletions(-)

[...]
         xfs_defer_init(&dfops, &first_block);

         /* RENAME_EXCHANGE is unique from here on. */
-       if (flags & RENAME_EXCHANGE)
-               return xfs_cross_rename(tp, src_dp, src_name, src_ip,
+       if (flags & RENAME_EXCHANGE) {
+               error = xfs_cross_rename(tp, src_dp, src_name, src_ip,
                                         target_dp, target_name, target_ip,
                                         &dfops, &first_block, spaceres);
-

You forgot to update parent pointers in RENAME_EXCHANGE
case, both src and target.

I commented that on v6, you must have missed that.

Thanks,
Amir.
Alrighty, I may have over looked it in all the traffic, I will get it updated. Thx!

Allison


--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux