On Wed, Jun 06, 2018 at 09:42:55PM -0700, Darrick J. Wong wrote: > On Thu, Jun 07, 2018 at 10:31:32AM +1000, Dave Chinner wrote: > > On Tue, Jun 05, 2018 at 09:56:03PM -0700, Darrick J. Wong wrote: > > > On Wed, Jun 06, 2018 at 02:06:24PM +1000, Dave Chinner wrote: > > > > On Tue, Jun 05, 2018 at 04:18:56PM -0700, Darrick J. Wong wrote: > > > > > On Mon, Jun 04, 2018 at 11:52:55AM +1000, Dave Chinner wrote: [big snip] I think we're in agreement with the direction we need to head, so rather than bikeshed it to death, I'll just say "yes, sounds like a good plan" and leave the rest to you, Darrick. :) > Ok, so two extra scrub ioctl flags, then: > > _IFLAG_FREEZE_OK /* userspace allows repair to freeze the fs */ > _OFLAG_AVOIDED_FREEZE /* would have done something but couldn't freeze */ > > I'll think about how to add a new scrubber to take care of the global > summary counters, and in the meantime I think I'll nominate online > rmapbt repair and online quotacheck for _IFLAG_FREEZE_OK. That's reasonable - I'm guessing the new global counter repair/scrubber will need this too? Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html