On Thu, Jun 07, 2018 at 08:34:38PM +0800, Eryu Guan wrote: > On Tue, Jun 05, 2018 at 09:43:20AM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > Test swapfile activation and deactivation. > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > --- > > tests/generic/708 | 115 +++++++++++++++++++++++++++++++++++++++++++++++++ > > tests/generic/708.out | 8 +++ > > tests/generic/709 | 91 +++++++++++++++++++++++++++++++++++++++ > > tests/generic/709.out | 3 + > > tests/generic/710 | 94 ++++++++++++++++++++++++++++++++++++++++ > > tests/generic/710.out | 3 + > > tests/generic/group | 3 + > > 7 files changed, 317 insertions(+) > > create mode 100755 tests/generic/708 > > create mode 100644 tests/generic/708.out > > create mode 100755 tests/generic/709 > > create mode 100644 tests/generic/709.out > > create mode 100755 tests/generic/710 > > create mode 100644 tests/generic/710.out > > > > > > diff --git a/tests/generic/708 b/tests/generic/708 > > new file mode 100755 > > index 00000000..dc3c2924 > > --- /dev/null > > +++ b/tests/generic/708 > > @@ -0,0 +1,115 @@ > > +#! /bin/bash > > +# FS QA Test No. 708 > > +# > > +# Test various swapfile activation oddities. > > +# > > +#----------------------------------------------------------------------- > > +# Copyright (c) 2018 Oracle. All Rights Reserved. > > +# > > +# This program is free software; you can redistribute it and/or > > +# modify it under the terms of the GNU General Public License as > > +# published by the Free Software Foundation. > > +# > > +# This program is distributed in the hope that it would be useful, > > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > +# GNU General Public License for more details. > > +# > > +# You should have received a copy of the GNU General Public License > > +# along with this program; if not, write the Free Software Foundation, > > +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > > +# > > +#----------------------------------------------------------------------- > > + > > +seq=`basename $0` > > +seqres=$RESULT_DIR/$seq > > +echo "QA output created by $seq" > > + > > +status=1 # failure is the default! > > +trap "_cleanup; exit \$status" 0 1 2 3 15 > > + > > +_cleanup() > > +{ > > + cd / > > + swapoff $swapfile 2> /dev/null > > + rm -f $swapfile > > No need to remove $swapfile which is on $SCRATCH_DEV, but need to remove > $tmp.* :) Ok. I remember deleting that for some reason, sorry for the thinko. > (Same in other tests) > > > +} > > + > > +# get standard environment, filters and checks > > +. ./common/rc > > +. ./common/filter > > + > > +# remove previous $seqres.full before test > > +rm -f $seqres.full > > + > > +# real QA test starts here > > +_supported_fs generic > > +_supported_os Linux > > +_require_scratch_swapfile > > +_require_test_program mkswap > > +_require_test_program swapon > > Need _require_xfs_io_command "fcollapse" too, and add 'collapse' group. Looking at this test I wonder wtf is going on, I thought I moved all the fcollapse bits to 710. Apparently I forgot to remove them from 708. > > + > > +rm -f $seqres.full > > +_scratch_mkfs >>$seqres.full 2>&1 > > +_scratch_mount >>$seqres.full 2>&1 > > + > > +swapfile=$SCRATCH_MNT/swap > > +len=$((2 * 1048576)) > > +page_size=$(get_page_size) > > + > > +swapfile_cycle() { > > + local swapfile="$1" > > + > > + $CHATTR_PROG +C $swapfile >> $seqres.full 2>&1 > > + "$here/src/mkswap" $swapfile >> $seqres.full > > + "$here/src/swapon" $swapfile 2>&1 | _filter_scratch > > + swapoff $swapfile 2>> $seeqres.full > > + rm -f $swapfile > > +} > > + > > +# Create a regular swap file > > +echo "regular swap" | tee -a $seqres.full > > +_pwrite_byte 0x58 0 $len $swapfile >> $seqres.full > > +swapfile_cycle $swapfile > > + > > +# Create a sparse swap file > > +echo "sparse swap" | tee -a $seqres.full > > +$XFS_IO_PROG -f -c "truncate $len" $swapfile >> $seqres.full > > +swapfile_cycle $swapfile > > This is already covered by generic/495. Ok, dropped. > > + > > +# Create a swap file with a little too much junk on the end > > +echo "too long swap" | tee -a $seqres.full > > +_pwrite_byte 0x58 0 $((len + 3)) $swapfile >> $seqres.full > > +swapfile_cycle $swapfile > > + > > +# Create a swap file with a large discontiguous range(?) > > +echo "large discontig swap" | tee -a $seqres.full > > +_pwrite_byte 0x58 0 $((len * 2)) $swapfile >> $seqres.full > > +old_sz="$(stat -c '%s' $swapfile)" > > +$XFS_IO_PROG -c "fcollapse $((len / 2)) $len" $swapfile >> $seqres.full 2>&1 > > +new_sz="$(stat -c '%s' $swapfile)" > > +if [ $old_sz -gt $new_sz ]; then > > + swapfile_cycle $swapfile > > +fi > > +rm -f $swapfile > > + > > +# Create a swap file with a small discontiguous range(?) > > +echo "small discontig swap" | tee -a $seqres.full > > +_pwrite_byte 0x58 0 $((len + 1024)) $swapfile >> $seqres.full > > +old_sz="$(stat -c '%s' $swapfile)" > > +$XFS_IO_PROG -c "fcollapse 66560 1024" $swapfile >> $seqres.full 2>&1 > > +new_sz="$(stat -c '%s' $swapfile)" > > +if [ $old_sz -gt $new_sz ]; then > > + swapfile_cycle $swapfile > > +fi > > +rm -f $swapfile > > Above two cases are duplicated in generic/710 below? Perhaps generic/710 > could be dropped. Nah, dropping these and letting 710 cover it, for those filesystems that support swapfiles but not fcollapse (e.g. ext2). > Thanks, > Eryu > > > + > > +# Create a ridiculously small swap file. Each swap file must have at least > > +# two pages after the header page. > > +echo "tiny swap" | tee -a $seqres.full > > +tiny_len=$((page_size * 3)) > > +_pwrite_byte 0x58 0 $tiny_len $swapfile >> $seqres.full > > +swapfile_cycle $swapfile > > + > > +status=0 > > +exit > > diff --git a/tests/generic/708.out b/tests/generic/708.out > > new file mode 100644 > > index 00000000..d002974c > > --- /dev/null > > +++ b/tests/generic/708.out > > @@ -0,0 +1,8 @@ > > +QA output created by 708 > > +regular swap > > +sparse swap > > +swapon: Invalid argument > > +too long swap > > +large discontig swap > > +small discontig swap > > +tiny swap > > diff --git a/tests/generic/709 b/tests/generic/709 > > new file mode 100755 > > index 00000000..5e636305 > > --- /dev/null > > +++ b/tests/generic/709 > > @@ -0,0 +1,91 @@ > > +#! /bin/bash > > +# FS QA Test No. 709 > > +# > > +# Test various swapfile activation oddities on filesystems that support > > +# fallocated swapfiles. > > +# > > +#----------------------------------------------------------------------- > > +# Copyright (c) 2018 Oracle. All Rights Reserved. > > +# > > +# This program is free software; you can redistribute it and/or > > +# modify it under the terms of the GNU General Public License as > > +# published by the Free Software Foundation. > > +# > > +# This program is distributed in the hope that it would be useful, > > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > +# GNU General Public License for more details. > > +# > > +# You should have received a copy of the GNU General Public License > > +# along with this program; if not, write the Free Software Foundation, > > +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > > +# > > +#----------------------------------------------------------------------- > > + > > +seq=`basename $0` > > +seqres=$RESULT_DIR/$seq > > +echo "QA output created by $seq" > > + > > +status=1 # failure is the default! > > +trap "_cleanup; exit \$status" 0 1 2 3 15 > > + > > +_cleanup() > > +{ > > + cd / > > + swapoff $swapfile 2> /dev/null > > + rm -f $swapfile > > +} > > + > > +# get standard environment, filters and checks > > +. ./common/rc > > +. ./common/filter > > + > > +# remove previous $seqres.full before test > > +rm -f $seqres.full > > + > > +# real QA test starts here > > +_supported_fs generic > > +_supported_os Linux > > +_require_scratch_swapfile > > +_require_test_program mkswap > > +_require_test_program swapon > > +_require_xfs_io_command "falloc" > > + > > +rm -f $seqres.full > > +_scratch_mkfs >>$seqres.full 2>&1 > > +_scratch_mount >>$seqres.full 2>&1 > > + > > +swapfile=$SCRATCH_MNT/swap > > +len=$((2 * 1048576)) > > +page_size=$(get_page_size) > > + > > +swapfile_cycle() { > > + local swapfile="$1" > > + > > + $CHATTR_PROG +C $swapfile >> $seqres.full 2>&1 > > + "$here/src/mkswap" $swapfile >> $seqres.full > > + "$here/src/swapon" $swapfile 2>&1 | _filter_scratch > > + swapoff $swapfile 2>> $seeqres.full > > + rm -f $swapfile > > +} > > + > > +# Create a fallocated swap file > > +echo "fallocate swap" | tee -a $seqres.full > > +$XFS_IO_PROG -f -c "falloc 0 $len" $swapfile >> $seqres.full > > +$CHATTR_PROG +C $swapfile >> $seqres.full 2>&1 > > +"$here/src/mkswap" $swapfile > > +"$here/src/swapon" $swapfile >> $seqres.full 2>&1 || \ > > + _notrun "fallocated swap not supported here" > > +swapoff $swapfile > > + > > +# Create a fallocated swap file and touch every other $PAGE_SIZE to create > > +# a mess of written/unwritten extent records > > +echo "mixed swap" | tee -a $seqres.full > > +$XFS_IO_PROG -f -c "falloc 0 $len" $swapfile >> $seqres.full > > +seq $page_size $((page_size * 2)) $len | while read offset; do > > + _pwrite_byte 0x58 $offset 1 $swapfile >> $seqres.full > > +done > > +swapfile_cycle $swapfile > > + > > +status=0 > > +exit > > diff --git a/tests/generic/709.out b/tests/generic/709.out > > new file mode 100644 > > index 00000000..90ba38ae > > --- /dev/null > > +++ b/tests/generic/709.out > > @@ -0,0 +1,3 @@ > > +QA output created by 709 > > +fallocate swap > > +mixed swap > > diff --git a/tests/generic/710 b/tests/generic/710 > > new file mode 100755 > > index 00000000..e9dc3f08 > > --- /dev/null > > +++ b/tests/generic/710 > > @@ -0,0 +1,94 @@ > > +#! /bin/bash > > +# FS QA Test No. 710 > > +# > > +# Test various swapfile activation oddities, having used fcollapse to > > +# create discontiguous ranges in the file. > > +# > > +#----------------------------------------------------------------------- > > +# Copyright (c) 2018 Oracle. All Rights Reserved. > > +# > > +# This program is free software; you can redistribute it and/or > > +# modify it under the terms of the GNU General Public License as > > +# published by the Free Software Foundation. > > +# > > +# This program is distributed in the hope that it would be useful, > > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > +# GNU General Public License for more details. > > +# > > +# You should have received a copy of the GNU General Public License > > +# along with this program; if not, write the Free Software Foundation, > > +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > > +# > > +#----------------------------------------------------------------------- > > + > > +seq=`basename $0` > > +seqres=$RESULT_DIR/$seq > > +echo "QA output created by $seq" > > + > > +status=1 # failure is the default! > > +trap "_cleanup; exit \$status" 0 1 2 3 15 > > + > > +_cleanup() > > +{ > > + cd / > > + swapoff $swapfile 2> /dev/null > > + rm -f $swapfile > > +} > > + > > +# get standard environment, filters and checks > > +. ./common/rc > > +. ./common/filter > > + > > +# remove previous $seqres.full before test > > +rm -f $seqres.full > > + > > +# real QA test starts here > > +_supported_fs generic > > +_supported_os Linux > > +_require_scratch_swapfile > > +_require_test_program mkswap > > +_require_test_program swapon > > +_require_xfs_io_command "fcollapse" > > + > > +rm -f $seqres.full > > +_scratch_mkfs >>$seqres.full 2>&1 > > +_scratch_mount >>$seqres.full 2>&1 > > + > > +swapfile=$SCRATCH_MNT/swap > > +len=$((2 * 1048576)) > > +page_size=$(get_page_size) > > + > > +swapfile_cycle() { > > + local swapfile="$1" > > + > > + "$here/src/mkswap" $swapfile >> $seqres.full > > + "$here/src/swapon" $swapfile 2>&1 | _filter_scratch > > + swapoff $swapfile 2>> $seeqres.full > > + rm -f $swapfile > > +} > > + > > +# Create a swap file with a large discontiguous range(?) > > +echo "large discontig swap" | tee -a $seqres.full > > +_pwrite_byte 0x58 0 $((len * 2)) $swapfile >> $seqres.full > > +old_sz="$(stat -c '%s' $swapfile)" > > +$XFS_IO_PROG -c "fcollapse $((len / 2)) $len" $swapfile >> $seqres.full 2>&1 > > +new_sz="$(stat -c '%s' $swapfile)" > > +if [ $old_sz -gt $new_sz ]; then > > + swapfile_cycle $swapfile > > +fi > > +rm -f $swapfile > > + > > +# Create a swap file with a small discontiguous range(?) > > +echo "small discontig swap" | tee -a $seqres.full > > +_pwrite_byte 0x58 0 $((len + 1024)) $swapfile >> $seqres.full > > +old_sz="$(stat -c '%s' $swapfile)" > > +$XFS_IO_PROG -c "fcollapse 66560 1024" $swapfile >> $seqres.full 2>&1 > > +new_sz="$(stat -c '%s' $swapfile)" > > +if [ $old_sz -gt $new_sz ]; then > > + swapfile_cycle $swapfile > > +fi > > +rm -f $swapfile > > + > > +status=0 > > +exit > > diff --git a/tests/generic/710.out b/tests/generic/710.out > > new file mode 100644 > > index 00000000..ba1f8e40 > > --- /dev/null > > +++ b/tests/generic/710.out > > @@ -0,0 +1,3 @@ > > +QA output created by 710 > > +large discontig swap > > +small discontig swap > > diff --git a/tests/generic/group b/tests/generic/group > > index 4339c64c..6d747450 100644 > > --- a/tests/generic/group > > +++ b/tests/generic/group > > @@ -497,3 +497,6 @@ > > 493 auto quick swap > > 494 auto quick swap punch > > 495 auto quick swap > > +708 auto quick swap > > +709 auto quick swap > > +710 auto quick swap collapse > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html