Re: [PATCH] xfs: use xfs_trans_getsb in xfs_sync_sb_buf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 04, 2018 at 06:50:05PM -0500, Eric Sandeen wrote:
> Use xfs_trans_getsb rather than reaching right in for
> mp->m_sb_bp; I think this is more correct, and it facilitates
> building this libxfs code in userspace as well.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> This passes the online label test ... tbh I'm not quite
> sure if I'm unwinding/unlocking/putting the bp properly
> here, though, so ... eyes & advice appreciated?

I think it's ok - the transaction context is gone with the commit,
so xfs_trans_brelse() would just call xfs_buf_relse() anyway.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux