Re: [PATCH 10/10] xfs: don't return garbage buffers in xfs_da3_node_read

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 03, 2018 at 04:23:27PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> If we're reading a node in a dir/attr btree and the buffer comes off the
> disk with a magic number we don't recognize, don't ASSERT and don't set
> a garbage buffer type (0 also triggers ASSERTs).  Instead, report the
> corruption, release the buffer, and return -EFSCORRUPTED because that's
> what the dabtree is -- corrupt.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Makes sense. I'm kinda surprised we haven't tripped over this given
that it looks like an obvious fuzzer target....

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux