On Sun, Jun 03, 2018 at 04:23:02PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > In xfs_dir2_leaf_addname we ASSERT if the length of the unused space > described by bestfree[0] is less the amount of space we wish to consume. > Immediately after it is a call to xfs_dir2_data_use_free where the > offset parameter is offset of the unused space and the length parameter > is the amount of space we wish to consume. Both values (and the unused > space pointer) are passed into xfs_dir2_data_check_free, which also > validates that the region of unused space is big enough to cover the > space we wish to consume. This is effectively the same check that the > ASSERT covers, and since a check failure results in a corruption message > being logged we can remove the ASSERT. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> Looks fine. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
