On Thu, May 31, 2018 at 09:33:57AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > The xfs_rtbuf_get function should check the block mapping it gets back > from bmapi_read. If there are no mappings or the mapping isn't a real > extent, we should return -EFSCORRUPTED rather than trying to read a > garbage value. We also require realtime bitmap blocks to be real, > written allocations. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> looks fine... Reviewed-by: Bill O'Donnell <billodo@xxxxxxxxxx> > --- > fs/xfs/libxfs/xfs_rtbitmap.c | 3 +++ > 1 file changed, 3 insertions(+) > > > diff --git a/fs/xfs/libxfs/xfs_rtbitmap.c b/fs/xfs/libxfs/xfs_rtbitmap.c > index 106be2d0bb88..7712f282d172 100644 > --- a/fs/xfs/libxfs/xfs_rtbitmap.c > +++ b/fs/xfs/libxfs/xfs_rtbitmap.c > @@ -90,6 +90,9 @@ xfs_rtbuf_get( > if (error) > return error; > > + if (nmap == 0 || !xfs_bmap_is_real_extent(&map)) > + return -EFSCORRUPTED; > + > ASSERT(map.br_startblock != NULLFSBLOCK); > error = xfs_trans_read_buf(mp, tp, mp->m_ddev_targp, > XFS_FSB_TO_DADDR(mp, map.br_startblock), > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
