On Wed, May 30, 2018 at 01:39:56PM -0400, Brian Foster wrote: > What if the file is reflinked and the current page covers a non-shared > block but has an overlapping cow mapping due to cowextsize? The current > logic unconditionally uses the COW mapping for writeback. The updated > logic doesn't appear to do that in all cases. Consider if the current > imap was delalloc (and so not trimmed) or the cow mapping was introduced > after the current imap was mapped. This logic appears to prioritize the > current mapping so long as it is valid. Doesn't that break the > cowextsize hint? It does. I've fixed it for the next version. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html