On Thu, May 31, 2018 at 09:11:56AM +1000, Dave Chinner wrote:
> On Wed, May 30, 2018 at 11:58:10AM +0200, Christoph Hellwig wrote:
> > This adds a simple iomap-based implementation of the legacy ->bmap
> > interface. Note that we can't easily add checks for rt or reflink
> > files, so these will have to remain in the callers. This interface
> > just needs to die..
> >
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> > Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> > ---
> > fs/iomap.c | 34 ++++++++++++++++++++++++++++++++++
> > include/linux/iomap.h | 3 +++
> > 2 files changed, 37 insertions(+)
> >
> > diff --git a/fs/iomap.c b/fs/iomap.c
> > index 74cdf8b5bbb0..b0bc928672af 100644
> > --- a/fs/iomap.c
> > +++ b/fs/iomap.c
> > @@ -1307,3 +1307,37 @@ int iomap_swapfile_activate(struct swap_info_struct *sis,
> > }
> > EXPORT_SYMBOL_GPL(iomap_swapfile_activate);
> > #endif /* CONFIG_SWAP */
> > +
> > +static loff_t
> > +iomap_bmap_actor(struct inode *inode, loff_t pos, loff_t length,
> > + void *data, struct iomap *iomap)
> > +{
> > + sector_t *bno = data, addr;
>
> Can you split these? maybe scope addr insie the if() branch it is
> used in?
This was intentional to avoid wasting another two lines on this
trivial, deprecated functionality..
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
