Re: [Cluster-devel] [PATCH 11/34] iomap: move IOMAP_F_BOUNDARY to gfs2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,


On 30/05/18 10:59, Christoph Hellwig wrote:
On Wed, May 30, 2018 at 10:30:32AM +0100, Steven Whitehouse wrote:
I may have missed the context here, but I thought that the boundary was a
generic thing meaning "there will have to be a metadata read before more
blocks can be mapped" so I'm not sure why that would now be GFS2 specific?
It was always a hack.  But with iomap it doesn't make any sensee to start
with, all metadata I/O happens in iomap_begin, so there is no point in
marking an iomap with flags like this for the actual iomap interface.

In that case,  maybe it would be simpler to drop it for GFS2. Unless we are getting a lot of benefit from it, then we should probably just follow the generic pattern here. Eventually we'll move everything to iomap, so that the bh mapping interface will be gone. That implies that we might be able to drop it now, to avoid this complication during the conversion.

Andreas, do you see any issues with that?

Steve.


--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux