On 5/29/18 9:56 AM, Darrick J. Wong wrote:
On Mon, May 28, 2018 at 04:11:36PM +0200, Carlos Maiolino wrote:
On Sun, May 27, 2018 at 08:53:04PM -0700, Allison Henderson wrote:
Seems like it would be ok. But if these functions are not really used,
is there a reason as to why we are just commenting them out instead of
removing them entirely? Thx!
I've the same question, I'd say you expect to keep them there for historical
reasons, but I think at least a comment in the patch description would be fine,
but either if you keep the commented code, or remove it completely:
It's hard to say -- xfsprogs ported the slice-by-8 code from the kernel,
then #if'd out some of the irrelevant bits. If we ever need to resync
w/ the kernel it'd be much easier to do so if the file is mostly intact
save for some preprocessor gunk to debloat the object files.
OTOH this file is ugly. Let's see if the maintainer accepts this or
yells 'rewrite!' :)
oh I had missed this.
.... 'rewrite!'
Let's just remove the unused stuff. We don't need it for libxfs-sync-ability
or libxfs-diff-happiness, so I'd say just nuke it. git history is there for
a reason.
V2 or another patch for later is fine though.
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
