Re: [PATCH v3 2/4] mkfs: move shared config structs and into their own headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 24, 2018 at 08:35:48PM -0700, Darrick J. Wong wrote:
> On Thu, May 24, 2018 at 08:19:41PM -0700, Luis R. Rodriguez wrote:
> > diff --git a/mkfs/config.h b/mkfs/config.h
> > new file mode 100644
> > index 000000000000..e5ea968e2d65
> > --- /dev/null
> > +++ b/mkfs/config.h
> > +struct mkfs_default_params {
> > +	char	*source;	/* where the defaults came from */
> > +
> > +	int	sectorsize;
> > +	int	blocksize;
> 
> Indentation ^^^ is uneven with the rest of the struct, but otherwise:

Bug-compatible :P -- ie it was in the old code IIRC, as all I did was
copy and paste on my editor between the two.

> Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux