Alrighty, looks ok. Thx!
Reviewed by: Allison Henderson <allison.henderson@xxxxxxxxxx>
On 05/22/2018 08:15 PM, Darrick J. Wong wrote:
From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
Examine all remote xattr values of a file, not just the XFS_ATTR_ROOT
values. This enables us to detect and zap corrupt user xattrs, as
tested by xfs/404.
Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
---
repair/attr_repair.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/repair/attr_repair.c b/repair/attr_repair.c
index 8b1b8a75..67bb41ec 100644
--- a/repair/attr_repair.c
+++ b/repair/attr_repair.c
@@ -537,9 +537,6 @@ process_leaf_attr_remote(
return -1;
}
- if (!(entry->flags & XFS_ATTR_ROOT))
- goto out;
-
value = malloc(be32_to_cpu(remotep->valuelen));
if (value == NULL) {
do_warn(
@@ -555,7 +552,8 @@ process_leaf_attr_remote(
i, ino);
goto bad_free_out;
}
- if (valuecheck(mp, (char *)&remotep->name[0], value, remotep->namelen,
+ if ((entry->flags & XFS_ATTR_ROOT) &&
+ valuecheck(mp, (char *)&remotep->name[0], value, remotep->namelen,
be32_to_cpu(remotep->valuelen))) {
do_warn(
_("remote attribute value check failed for entry %d, inode %" PRIu64 "\n"),
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at https://urldefense.proofpoint.com/v2/url?u=http-3A__vger.kernel.org_majordomo-2Dinfo.html&d=DwIBAg&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=LHZQ8fHvy6wDKXGTWcm97burZH5sQKHRDMaY1UthQxc&m=Vc_K6AveietpcEeQdJ30FwiEHLOuaBg_hGM_aW3IuTM&s=0ZEyUF20gQ7jZ-6j_k9Nsrddrvue9p8Wr6Xo9hwqMZE&e=
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
