Re: [PATCH 05/34] fs: use ->is_partially_uptodate in page_cache_seek_hole_data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > diff --git a/fs/iomap.c b/fs/iomap.c
> > index bef5e91d40bf..0fecd5789d7b 100644
> > --- a/fs/iomap.c
> > +++ b/fs/iomap.c
> > @@ -594,31 +594,54 @@ EXPORT_SYMBOL_GPL(iomap_fiemap);
> >   *
> >   * Returns the offset within the file on success, and -ENOENT otherwise.
> 
> This comment is now wrong, since we return the offset via *lastoff and I
> think the return value is whether or not we found what we were looking
> for...?

Yes.  I'll just drop the comment as it doesn't add much value to start
with.

> > +	if (bsize == PAGE_SIZE || !ops->is_partially_uptodate) {
> > +		if (PageUptodate(page) == seek_data)
> > +			return true;
> > +		return false;
> 
> return PageUptodate(page) == seek_data; ?

Sure, I'll uptodate the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux