On Mon, May 21, 2018 at 08:33:54AM -0700, Darrick J. Wong wrote: > On Sun, May 20, 2018 at 10:16:48AM +1000, Dave Chinner wrote: > > On Thu, May 17, 2018 at 08:46:00PM -0700, Darrick J. Wong wrote: > > > On Thu, May 17, 2018 at 10:24:13PM -0500, Eric Sandeen wrote: > > > > On 5/17/18 2:27 PM, Luis R. Rodriguez wrote: > > > > > You may want to stick to specific set of configuration options when > > > > > creating filesystems with mkfs.xfs -- sometimes due to pure technical > > > > > reasons, but some other times to ensure systems remain compatible as > > > > > new features are introduced with older kernels, or if you always want > > > > > to take advantage of some new feature which would otherwise typically > > > > > be disruptive. > > > > > > > > > > This adds support for parsing a configuration file to override defaults > > > > > parameters to be used for mkfs.xfs. > > > > > > > > > > We define an XFS configuration directory,/etc/mkfs.xfs.d/ and allow for > > > > > different configuration files, if none is specified we look for the > > > > > default configuration file, /etc/mkfs.xfs.d/default. You can override > > > > > with -c. For instance, if you specify: > > > > > > > > > > mkfs.xfs -c experimental -f /dev/loop0 > > > > > > > > > > The file /etc/mkfs.xfs.d/experimental will be used as your configuration > > > > > file. If you really need to override the full path of the configuration > > > > > file you may use the MKFS_XFS_CONFIG environment variable. > > > > > > > > I'm swamped under a deadline at work this week so just commenting at a > > > > very high level for now, but I'm curious; why use an env var vs > > > > providing a full path for -c ? env vars always strike me as magic unexpected > > > > behaviors. > > > > > > > > # mkfs.xfs -c /my/fancy/path/to/config > > > > > > > > seems much clearer than > > > > > > > > # export MKFS_XFS_CONFIG=/my/fancy/path/to/ > > > > # mkfs.xfs -c config > > > > > > > > i.e. if a full path is specified use it, else use the config directory. > > > > > > > > Thoughts? > > > > > > In this case your choices are: > > > MKFS_XFS_CONFIG=/my/fancy/path/to/config mkfs.xfs > > > > > > or: > > > cp /my/fancy/path/to/config /etc/mkfs.xfs.d/hoogah > > > mkfs.xfs -c hooga > > > > Sorry, why do we need to copy it to /etc/mkfs.xfs.d/? > > No particular reason, just showing off relative pathname interpretation. > That could have been > > mkfs.xfs -c ../../my/fancy/path/to/config > > But that's kinda ugly. $sysconfdir seems to get set to /usr on my > local builds, though I think dpkg overrides that back to /... :) You will need to set: --sysconfdir=/etc And the spec file / debian/control file will need to be update to use this on the configure line. > > > <shrug> Bikeshedding more, what if either option accepted either an > > > absolute path, or a file in $sysconfdir/etc/mkfs.xfs.d/ ? > > > > I kinda assumed that config files could be located anywhere, but we > > only searched the sysconfig path if it didn't point at a local > > file... > > <shrug> openat() semantics are fine enough with me, I think. Well this is a big difference, and I think being clear on this would be good. If the user specified: -c foo and the file 'foo' is present but also exists on $sysconfdir/etc/mkfs.xfs.d/foo do we use the local file if the user did not pass ./foo ? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
