On Fri, May 18, 2018 at 10:49:58AM +1000, Dave Chinner wrote: > On Thu, May 17, 2018 at 04:54:03PM -0700, Luis R. Rodriguez wrote: > > > > diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c > > > > index 95cd6ced13f0..ac97039abc34 100644 > > > > --- a/mkfs/xfs_mkfs.c > > > > +++ b/mkfs/xfs_mkfs.c > > > > @@ -20,6 +20,8 @@ > > > > #include <ctype.h> > > > > #include "xfs_multidisk.h" > > > > #include "libxcmd.h" > > > > +#include "xfs_mkfs_common.h" > > > > +#include "xfs_mkfs_cli.h" > > > > > > #include "config.h" > > > > You mean input.h ? The config.h would be for the configuration file, no? > > I suggested both config.h and input.h as potential candidates. Given > that you use config.h in a later patch, i'd suggest that config.h is > the right name for this. And the configuration header name? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html