Re: [PATCH v2 1/2] iomap: provide more useful errors for invalid swap files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 16, 2018 at 11:11:42AM -0700, Darrick J. Wong wrote:
> That's what I thought -- we only see NULL_ADDR for holes and delalloc
> extents, and we already check for both of those.  But I didn't see
> anything in iomap.h expressly saying that, so I decided to be defensive
> and check it anyway.
> 
> IOWs it would be helpful to have a little more documentation about which
> flags go together,

patches welcome :)

> particularly for things like IOMAP_F_BOUNDARY that
> don't have any meaning in xfs.

Yikes, how did that even end in the tree?  That whole boundary
thing already made little sene on buffer heads, and even less
so in the generic iomap code.  I think we just need to allocate
a few flags for fs specific uses and move it into gfs2.

--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux