[PATCH v2] xfs: refactor and tablise growfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi folks,

This is an update of the patch set I sent a while ago, and
Eric and Darrick have been bugging me to get sorted. The last
posting was here:

https://marc.info/?l=linux-xfs&m=151746732826277&w=2

This update addresses most of the comments that were made at the
time. most importantly, it gets rid of the use of uncached buffers
for secondary superblocks. Instead, I introduced a small helper to
mark a buffer as a "one-shot" buffer, which will cause the buffer to
be reclaimed when all active references go away rather than being
put on the LRU. If teh buffer is already on the LRU, then it
respects that and does not change the buffer behaviour (similar to
XFS_IGET_DONTCACHE for inodes).  THis means the growfs code will
play nicely with scrub and other occasional users of secondary
superblocks, but not add any long term cache footprint.

The other addition since the last posting is moving all the code
that does the AG header setup to libxfs so it canbe shared with
userspace(*). Most of the functions have been moved to new files
fs/xfs/libxfs/xfs_ag.[ch], but the secondary superblock update got
moved to fs/xfs/libxfs/xfs_sb.c, because it's purely about
superblock updates.

The pastchset just passed an overnight QA run on v4 and v5
filesystems w/ both 1k and 4k block sizes.

Comments?

-Dave.

Version 2:
- rebase on current for-next
- add oneshot cached buffer support
- clean up more of the typedef usage.
- move id->nfree calc to per-ag hdr init function from the freespace
  btree root initialisation.
- only use id->type and id->numrecs for the generic btree root block
  init calls.
- only call xfs_growfs_data_private() if the size is actually being
  changed.
- make sure we still update secondary superblocks if physical grow
  fails with ENOSPC.
- change secondary superblock updates to use cached one-shot
  buffers.
- moved the core code to libxfs so it can be shared easily with
  userspace.

(*) e.g. mkfs. More interestingly, this provides a mechanism for a
simple offline grow implementation to be added to xfs_spaceman for
vm/container deployment infrastructures that have to mount an fs
image just to grow it during their setup phase.


--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux