On Wed, May 09, 2018 at 08:45:01AM -0700, Matthew Wilcox wrote: > On Wed, May 09, 2018 at 09:48:03AM +0200, Christoph Hellwig wrote: > > It counts the number of pages acted on, so name it nr_pages to make that > > obvious. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > Yes! > > Also, it can't return an error, so how about changing it to unsigned int? > And deleting the error check from the caller? I'll take a look at that. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html