On Wed, May 09, 2018 at 08:12:43AM -0700, Matthew Wilcox wrote: > (page, len, off) is a bit weird to me. Usually we do (page, off, len). That's what I'd usually do, too. But this odd convention is what bio_add_page uses, so I decided to stick to that instead of having two different conventions in one family of functions. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html