We already track the page uptodate status based on the buffer uptodate
status, which is updated whenever reading or zeroing blocks.
This code has been there since commit a ptool commit in 2002, which
claims to:
"merge" the 2.4 fsx fix for block size < page size to 2.5. This needed
major changes to actually fit.
and isn't present in other writepage implementations.
Signed-off-by: Christoph Hellwig <hch@xxxxxx>
---
fs/xfs/xfs_aops.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index dc82d4e71a64..dc92f23b0ea4 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -812,7 +812,6 @@ xfs_writepage_map(
ssize_t len = i_blocksize(inode);
int error = 0;
int count = 0;
- bool uptodate = true;
loff_t file_offset; /* file offset of page */
unsigned poffset; /* offset into page */
@@ -840,7 +839,6 @@ xfs_writepage_map(
if (bh && !buffer_uptodate(bh)) {
if (PageUptodate(page))
ASSERT(buffer_mapped(bh));
- uptodate = false;
bh = bh->b_this_page;
continue;
}
@@ -880,9 +878,6 @@ xfs_writepage_map(
count++;
}
- if (uptodate && poffset == PAGE_SIZE)
- SetPageUptodate(page);
-
ASSERT(wpc->ioend || list_empty(&submit_list));
out:
--
2.17.0
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
