On Tue, May 08, 2018 at 03:52:37PM -0500, Eric Sandeen wrote: > On 5/7/18 11:41 PM, Allison Henderson wrote: > > From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> > > > > Add ioctl definitions to libxfs, build the necessary helpers into > > libfrog and libhandle to iterate parents (and parent paths), then wire > > up xfs_scrub to be able to query parent pointers from userspace. The > > goal of this patch is to exercise userspace, and is nowhere near a > > complete solution. A basic xfs_io parent command implementation > > replaces ... whatever that is that's there now. > > I wonder if it'd be better to send a patch to nuke the current parent code, > and then another to add back something that works. Same result in the end, > but it doesn't look like you're trying to fix old code; the patch itself is > pretty meaningless since it diffs against nonfunctional(?) code. Trouble is, it's exported as a shared library in the xfslibs-dev package (should that be libxfs-dev?) so depending on how conservative you like to be we can't just rip it out. (Though I suppose even Linus has occasionally allowed people to rip and replace kernel/user ABIs when they can demonstrate that it was so broken it never worked for anybody, ever. :P) > Not a huge deal, just a thought. Yeah, this patch was quite quick and dirty when I wrote it, on the assumption that tons of other stuff was going to need reorganization by the time there was a need to land this. --D > -Eric > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
