On 5/8/18 12:43 PM, Darrick J. Wong wrote: > On Mon, May 07, 2018 at 09:41:18PM -0700, Allison Henderson wrote: >> Signed-off-by: Allison Henderson <allison.henderson@xxxxxxxxxx> >> --- >> mkfs/proto.c | 59 ++++++++++++++++++++++++++++++++++------------------ >> repair/attr_repair.c | 16 ++------------ >> repair/phase6.c | 47 +++++++++++++++++++++++++---------------- > Separate patches for separate utilities, please. Or at least patch per functional change; it's not at all clear to me how protofile creation has anything to do with xfs_repair, and there's nothing in the commit log to help me figure it out. :) (I think it doesn't have anything to do w/ protofile creation, and the repair patches are fixing up orphanage entry creation; the attr_repair changes seem like some third thing that I don't grok yet, sorry - removing namecheck() for some reason?). -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html