On 5/8/18 11:13 AM, hal@xxxxxxxxxxxx wrote: <snip totally acceptable & legit reasons for needing this> ;) >> Otherwise I might suggest adding a switch specific to the blockget_f >> function, which would just skip the sb_logcheck() altogether. That would >> be more targeted, and wouldn't be some global switch which affects >> every current and future caller of sb_logcheck. A warning about how >> the log is being ignored and results may be inconsistent could then >> be added specifically to blockget_f. > Which sort of brings us back to the conversation that Darrick and I > have been having. Adding a command-line switch seems wrong-- I'm fully > convinced of that. But I'd still like to be able to blockget to try > to work if the file system is dirty but "-r" is used. Right, but my concern with "-r" or anything implying "readonly" as a modifier is that check & blockget are /always/ readonly. A readonly modifier to a readonly command makes little sense IMHO. > Darrick came up with one fix, which is the first patch option below. > After staring at Darrick's suggestion a while, I came up with a > different fix (second patch) that requires more code changes but I > think more accurately addresses the problem statement. See previous > messages in this thread for more detail. Yup, I have read them. > Let me know which you prefer and I'll submit the patch in the proper > format to the list. Well, I don't really like either patch for the reasons stated above. xfs_db /can/ write to the filesystem, and -r disables that... but -r as a modifier to affect the behavior of a read-only command is unintuitive. "It is only necessary to omit this flag if a command that changes data (write, blocktrash, crc) is to be used." What are the objections to a blockget modifier option? That seemed like the most direct & obvious solution to me. "blockget/check -L : attempt to perform the blockget and check functions even if the log contains unreplayed metadata," or something like that? Thanks, -Eric > Cheers! > > --Hal > > -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
