> Why skip the warning? I think xfs_db should always warn on a dirty log, > but perhaps we could relax the 'return 0' at the end of this hunk if the > fs was opened readonly? > > i.e. > > dbprintf(_("ERROR: The filesystem has...")); > return (x.isreadonly & LIBXFS_ISREADONLY) ? 1 : 0; > > which would also make adding the -R option unnecessary. I like this solution very much. I'll send in this patch in a separate email. Hal Pomeranz -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html