On 4/17/18 9:47 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>
> During phase 3, we check the '.' entry of a directory inode and (in
> modify mode) zap it if the name isn't valid. During phase 6, we assert
> that the '.' entry now reflects the correct name. In no-modify mode
> this is incorrect because we didn't actually fix anything, so repair
> asserts and crashes.
>
> Found by fuzzing bu[0].namelen = 4 in xfs/387 and running xfs_repair -n.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> repair/phase6.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
> diff --git a/repair/phase6.c b/repair/phase6.c
> index 2005e40..e65fc4a 100644
> --- a/repair/phase6.c
> +++ b/repair/phase6.c
> @@ -1884,7 +1884,8 @@ longform_dir2_entry_check_data(
> * of when directory is moved to orphanage.
> */
> if (ip->i_ino == inum) {
> - ASSERT(dep->name[0] == '.' && dep->namelen == 1);
> + ASSERT(no_modify ||
> + (dep->name[0] == '.' && dep->namelen == 1));
> add_inode_ref(current_irec, current_ino_offset);
> if (da_bno != 0 ||
> dep != M_DIROPS(mp)->data_entry_p(d)) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
