On Fri, May 04, 2018 at 04:31:56PM -0500, Eric Sandeen wrote: > On 3/13/18 10:21 PM, Eric Sandeen wrote: > >> There is only a subset of options allowed to be set on the configuration > >> file, > > > I think this is problematic - allowing only booleans is pretty > > arbitrary. > > ... > > >> and currently only 1 or 0 are acceptable values. The default > >> parameters you can override on a configuration file and their current > >> built-in default settings are: > >> > >> [data] > >> noalign=0 > > ... > > >> We have floated around enough bike shedding emails to have at least reached > >> a consensus on the fact that we'd be only supporting a mimimum set of default > >> parameters and would strive to simplify our parser as much as possible. > > > See above - sorry for not chiming in sooner, but I don't think an arbitrary > > restriction to the boolean options will be sufficient in the long run. > > Ok, I'm rethinking this concern now. > > It seems like we may have two separate but related purposes for a mkfs config file: > > 1) Set system-wide defaults based on kernel and/or OS support. > 2) Set specific-use defaults, such as "mkfs.xfs -c gluster" etc. > > For the former, it may well only be the booleans that matter. For the latter, > it may be more, like setting inode size, or directory block size, etc. > > Is there anything we'd reasonably want to set system-wide that's /not/ a > boolean? If not, the maybe that can be Phase 1 as long as the config file > format doesn't need to change; we can just add to the list of supported config > options at a later date, perhaps? Looking at the *documented* mkfs options, I think it'd be useful for cloud users to be able to set cowextsize and extsize from mkfs. As I was saying on irc, I /think/ the options (Allison feel free to chime in here) that we want are.... -m crc,finobt,rmapbt,reflink,projinherit,extszinherit,cowextsize,extsize -i maxpct,sparse -n ftype --D > The system-wide, supported-features default config may be the most pressing > need at this point, the rest is just nice to have. > > Thanks, > -Eric > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
