On 5/4/18 3:25 PM, Darrick J. Wong wrote: > On Fri, May 04, 2018 at 02:29:55PM -0500, Eric Sandeen wrote: >> On 4/17/18 9:46 PM, Darrick J. Wong wrote: >>> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> >>> >>> Validate the log space information in a similar manner to the kernel so >>> that repair will stumble over (and fix) broken log info that prevents >>> mounting. Fixes logsunit fuzz-and-fix failures in xfs/350. ... >> Hm, this could use a comment about why these things only matter on v5 supers. > > /* > * We only do this validation on v5 filesystems because the kernel > * didn't reject too-small logs in the past. > */ > > ? "... doesn't reject malformed logs on older revision filesystems" also, it'll probably happen anyway, but the new check-stuff function should probably be called on its own and not tacked on via || to the inode checks. -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
