Re: [PATCH 02/11] xfs_repair: don't leak buffer on xattr remote buf verifier error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 4/17/18 9:46 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> If we try to read an xattr remote buffer and hit a verifier error,
> release the buffer instead of leaking it.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Good plan.

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

> ---
>  repair/attr_repair.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> 
> diff --git a/repair/attr_repair.c b/repair/attr_repair.c
> index bb5ab3d..3e6efd0 100644
> --- a/repair/attr_repair.c
> +++ b/repair/attr_repair.c
> @@ -433,6 +433,7 @@ rmtval_get(xfs_mount_t *mp, xfs_ino_t ino, blkmap_t *blkmap,
>  		if (bp->b_error == -EFSBADCRC || bp->b_error == -EFSCORRUPTED) {
>  			do_warn(
>  	_("Corrupt remote block for attributes of inode %" PRIu64 "\n"), ino);
> +			libxfs_putbuf(bp);
>  			clearit = 1;
>  			break;
>  		}
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux