Re: [PATCH 2/9] libfrog: refactor fs geometry printing function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/17/18 9:45 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> Move the fs geometry printing function to libfrog so that mkfs and others
> can share.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>


> +	printf(_(
> +"meta-data=%-22s isize=%-6d agcount=%u, agsize=%u blks\n"
> +"         =%-22s sectsz=%-5u attr=%u, projid32bit=%u\n"
> +"         =%-22s crc=%-8u finobt=%u, sparse=%u, rmapbt=%u\n"
> +"         =%-22s reflink=%u\n"
> +"data     =%-22s bsize=%-6u blocks=%llu, imaxpct=%u\n"
> +"         =%-22s sunit=%-6u swidth=%u blks\n"
> +"naming   =version %-14u bsize=%-6u ascii-ci=%d, ftype=%d\n"
> +"log      =%-22s bsize=%-6d blocks=%u, version=%d\n"
> +"         =%-22s sectsz=%-5u sunit=%d blks, lazy-count=%d\n"
> +"realtime =%-22s extsz=%-6d blocks=%lld, rtextents=%lld\n"),

Actually, I'd like to put a whitespace break here as there was in old code,
as this is a giant, dense blob of code that's pretty hard to grok visually.

Any objection? :)

-Eric

> +		mntpoint, geo->inodesize, geo->agcount, geo->agblocks,
> +		"", geo->sectsize, attrversion, projid32bit,
> +		"", crcs_enabled, finobt_enabled, spinodes, rmapbt_enabled,
> +		"", reflink_enabled,
> +		"", geo->blocksize, (unsigned long long)geo->datablocks,
> +			geo->imaxpct,
> +		"", geo->sunit, geo->swidth,
> +		dirversion, geo->dirblocksize, cimode, ftype_enabled,
> +		isint ? _("internal log") : logname ? logname : _("external"),
> +			geo->blocksize, geo->logblocks, logversion,
> +		"", geo->logsectsize, geo->logsunit / geo->blocksize, lazycount,
> +		!geo->rtblocks ? _("none") : rtname ? rtname : _("external"),
> +		geo->rtextsize * geo->blocksize, (unsigned long long)geo->rtblocks,
> +			(unsigned long long)geo->rtextents);
> +}
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux