On Wed, May 2, 2018 at 10:55 AM, Eryu Guan <guaneryu@xxxxxxxxx> wrote: > On Tue, May 01, 2018 at 08:40:10AM -0700, Darrick J. Wong wrote: >> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> >> >> Find all the /bin/sh scripts in xfsprogs and check for bashisms. >> >> Cc: sandeen@xxxxxxxxxxx >> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Looks fine to me, but I'd like a review from Eric too, as it's a > "maintainer script" :) > A good idea, looks generally ok to me (and now we really wait for Eric). [snip] >> + >> +find $WORKAREA -name 'xfs*.sh' -print0 | xargs -0 grep '^#!/bin/sh' | sed -e 's/:.*$//g' | while read f; do > > Do we care about spaces between "#!" and "/bin/sh"? i.e. "#! /bin/sh", > sometimes there can be space(s). > As far as I know, spaces are completely OK and allowed and accepted everywhere, so I would add them here too. Jan -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
