On Sun, Apr 29, 2018 at 08:15:28PM -0500, Eric Sandeen wrote:
> It was pointed out on irc that fsck.xfs uses the 'function' keyword
> although it invokes /bin/sh - 'function' is a bashism. It's not needed
> here, so just remove it.
>
> Fixes: 04a2d5d ("fsck.xfs: allow forced repairs using xfs_repair")
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
Does RHEL have 'checkbashisms'?
Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
--D
> ---
>
> This might be a 4.16.1 item, if strict-sh initscripts fail to run fsck.xfs at
> boot time ...?
>
> diff --git a/fsck/xfs_fsck.sh b/fsck/xfs_fsck.sh
> index c9fc3eb..1916c07 100755
> --- a/fsck/xfs_fsck.sh
> +++ b/fsck/xfs_fsck.sh
> @@ -6,7 +6,7 @@
> NAME=$0
>
> # get the right return code for fsck
> -function repair2fsck_code() {
> +repair2fsck_code() {
> case $1 in
> 0) return 0 # everything is ok
> ;;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
