On Mon, Apr 23, 2018 at 07:32:57PM +0200, Christoph Hellwig wrote: > On Sun, Apr 22, 2018 at 08:06:58AM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > Move the _qm_dqread functionality to _qm_dqensure, then remove the flags > > argument from xfs_qm_dqread since the only DQALLOC users were internal > > to xfs_dquot.c anyway. > > Unless this makes something much easier later in the series I'd rather > not change the names and calling conventions here. dqensure just sounds > very weird, and having dqread is a trivial wrapper for it also doesn't > seem to be very intuitive. How about xfs_dquot_setup for a name instead of dqensure? The purpose of making dqread a trivial wrapper is so that we can drop the flags parameter from dqread which is always zero. Later on in the quotacheck repair patch I'll have a repair-specific use of the _setup function and friends. --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
